On Sat, 10 Sep 2022 22:42:33 +0300, Serge Semin wrote:
> The DT-schema name and the corresponding generic compatible string look
> inappropriate in the current DW uMCTL2 DDRC DT-bindings:
> 1. DT-schema name contains undefined vendor-prefix. It's supposed to be
> "snps", not "synopsys".
> 2. DT-schema name has "ecc" suffix. That is a device property, and has
> nothing to do with the controller actual name.
> 3. The controller name is different. It's DW uMCTL2 DDRC. Just DDRC
> doesn't identify the IP-core in subject.
> 4. There is no much point in using the IP-core version in the device name
> since it can be retrieved from the corresponding device CSR. Moreover the
> DW uMCTL2 DDRC driver doesn't differentiate the IP-core version at the
> current state.
>
> In order to fix all the inconsistencies described above we suggest to
> rename the DT-schema to "snps,dw-umctl2-ddrc.yaml", deprecate the
> compatible string "snps,ddrc-3.80a" and define a new generic device
> name as "snps,dw-umctl2-ddrc".
>
> Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx>
>
> ---
>
> Changelog v2:
> - This is a new patch created on v2 by detaching the DT-schema renaming
> from the previous patch in the series. (@Krzysztof)
> - Fix the compatible string name so one would match the new DT-schema
> name.
> ---
> .../{synopsys,ddrc-ecc.yaml => snps,dw-umctl2-ddrc.yaml} | 7 +++++--
> MAINTAINERS | 1 +
> 2 files changed, 6 insertions(+), 2 deletions(-)
> rename Documentation/devicetree/bindings/memory-controllers/{synopsys,ddrc-ecc.yaml => snps,dw-umctl2-ddrc.yaml} (83%)
>
Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
