On 24/07/2022 17:04, Dmitry Baryshkov wrote:
The commit 90173a954a22 ("arm64: dts: qcom: msm8996: Add CPU opps") added CPU OPP tables to msm8996.dtsi. However it went unnoticed that MSM8996 and MSM8996Pro have significant differences in the supported CPU frequencies. Moreover, differences between various speed bins were also not handled in the DT. Fix all these issues by splitting msm8996pro and fixing different opp-supported-hw. Unlike previous attempts by Yassine Oudjana [1] [2], this patchset doesn't require changing the cpufreq driver, keeping compatibility with existing kernels (and thus easing backporting to stable kernels). Yassine's patches were changed to keep compatibility. While we are at it, also apply fixes to GPU OPP tables to acount for small differences in supported frequencies. [1] https://lore.kernel.org/linux-arm-msm/20220409035804.9192-1-y.oudjana@xxxxxxxxxxxxxx/ [2] https://lore.kernel.org/linux-arm-msm/20220416025637.83484-1-y.oudjana@xxxxxxxxxxxxxx/ Dmitry Baryshkov (5): dt-bindings: arm: qcom: separate msm8996pro bindings arm64: dts: qcom: msm8996: fix supported-hw in cpufreq OPP tables arm64: dts: qcom: msm8996: add support for speed bin 3 arm64: dts: qcom: msm8996: fix GPU OPP table arm64: dts: qcom: msm8996pro: expand Adreno OPP table Yassine Oudjana (2): arm64: dts: qcom: msm8996: Add MSM8996 Pro support arm64: dts: qcom: msm8996-xiaomi-scorpio, natrium: Use MSM8996 Pro .../devicetree/bindings/arm/qcom.yaml | 5 + arch/arm64/boot/dts/qcom/Makefile | 4 +- .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 3 - .../boot/dts/qcom/msm8996-xiaomi-gemini.dts | 1 + arch/arm64/boot/dts/qcom/msm8996.dtsi | 112 ++++--- ...rium.dts => msm8996pro-xiaomi-natrium.dts} | 3 +- ...rpio.dts => msm8996pro-xiaomi-scorpio.dts} | 3 +- arch/arm64/boot/dts/qcom/msm8996pro.dtsi | 291 ++++++++++++++++++ 8 files changed, 369 insertions(+), 53 deletions(-) rename arch/arm64/boot/dts/qcom/{msm8996-xiaomi-natrium.dts => msm8996pro-xiaomi-natrium.dts} (99%) rename arch/arm64/boot/dts/qcom/{msm8996-xiaomi-scorpio.dts => msm8996pro-xiaomi-scorpio.dts} (99%) create mode 100644 arch/arm64/boot/dts/qcom/msm8996pro.dtsi
Gracious ping. It would be nice to get CPU OPP tables sorted out. -- With best wishes Dmitry