On Fri, Aug 26, 2022 at 06:56:21AM +0000, Judy Hsiao wrote: > Fix the DMIC no sound issue of villager-r1 by using "PP1800_L2C" as the > DMIC power source to match the hardware schematic. > > This patch: > 1. set vdd-micb-supply to PP1800_L2C as the MIC Bias voltage regulator. > 2. In audio-routing, set VA DMIC01~VA DMIC03 to use the vdd-micb-supply > setting. > > Co-developed-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx> > Signed-off-by: Srinivasa Rao Mandadapu <quic_srivasam@xxxxxxxxxxx> > Signed-off-by: Judy Hsiao <judyhsiao@xxxxxxxxxxxx> > --- > Changes since V3: > -- Update the commit message and fix extra blank line. > Changes since V2: > -- Update the commit message. > Changes since V1: > -- Update the commit message. > > This patch depends on: > arm64: dts: qcom: sc7280: Add herobrine-villager-r1. [1] > > [1] https://patchwork.kernel.org/patch/12929106 With [1] applied this patch applies cleanly, but it doesn't built. What am I missing? Regards, Bjorn > > .../dts/qcom/sc7280-herobrine-villager-r1.dts | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > index c03b3ae4de50..fd202a8f6a33 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r1.dts > @@ -12,3 +12,30 @@ / { > model = "Google Villager (rev1+)"; > compatible = "google,villager", "qcom,sc7280"; > }; > + > +&lpass_va_macro { > + vdd-micb-supply = <&pp1800_l2c>; > +}; > + > +&sound { > + audio-routing = > + "IN1_HPHL", "HPHL_OUT", > + "IN2_HPHR", "HPHR_OUT", > + "AMIC1", "MIC BIAS1", > + "AMIC2", "MIC BIAS2", > + "VA DMIC0", "vdd-micb", > + "VA DMIC1", "vdd-micb", > + "VA DMIC2", "vdd-micb", > + "VA DMIC3", "vdd-micb", > + "TX SWR_ADC0", "ADC1_OUTPUT", > + "TX SWR_ADC1", "ADC2_OUTPUT", > + "TX SWR_ADC2", "ADC3_OUTPUT", > + "TX SWR_DMIC0", "DMIC1_OUTPUT", > + "TX SWR_DMIC1", "DMIC2_OUTPUT", > + "TX SWR_DMIC2", "DMIC3_OUTPUT", > + "TX SWR_DMIC3", "DMIC4_OUTPUT", > + "TX SWR_DMIC4", "DMIC5_OUTPUT", > + "TX SWR_DMIC5", "DMIC6_OUTPUT", > + "TX SWR_DMIC6", "DMIC7_OUTPUT", > + "TX SWR_DMIC7", "DMIC8_OUTPUT"; > +}; > -- > 2.37.2.672.g94769d06f0-goog >
