Re: [PATCH 2/6] arm64: dts: imx8mp-venice-gw74xx: remove invalid and unused pinctrl_sai2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 22, 2022 at 10:03 AM Tim Harvey <tharvey@xxxxxxxxxxxxx> wrote:
>
> On Fri, Aug 12, 2022 at 10:35 AM Tim Harvey <tharvey@xxxxxxxxxxxxx> wrote:
> >
> > pinctrl_sai2 is not yet used and not properly defined - remove it to
> > avoid:
> > imx8mp-pinctrl 30330000.pinctrl: Invalid fsl,pins or pins propert
> > y in node /soc@0/bus@30000000/pinctrl@30330000/sai2grp
> >
> > Fixes: 7899eb6cb15d ("arm64: dts: imx: Add i.MX8M Plus Gateworks gw7400 dts
> > support")
> > Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts | 9 ---------
> >  1 file changed, 9 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > index de17021df53f..80f0f1aafdbf 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-venice-gw74xx.dts
> > @@ -768,15 +768,6 @@ MX8MP_IOMUXC_NAND_DATA03__GPIO3_IO09       0x110
> >                 >;
> >         };
> >
> > -       pinctrl_sai2: sai2grp {
> > -               fsl,pins = <
> > -                       MX8MP_IOMUXC_SAI2_TXFS__AUDIOMIX_SAI2_TX_SYNC
> > -                       MX8MP_IOMUXC_SAI2_TXD0__AUDIOMIX_SAI2_TX_DATA00
> > -                       MX8MP_IOMUXC_SAI2_TXC__AUDIOMIX_SAI2_TX_BCLK
> > -                       MX8MP_IOMUXC_SAI2_MCLK__AUDIOMIX_SAI2_MCLK
> > -               >;
> > -       };
> > -
> >         pinctrl_spi2: spi2grp {
> >                 fsl,pins = <
> >                         MX8MP_IOMUXC_ECSPI2_SCLK__ECSPI2_SCLK   0x82
> > --
> > 2.25.1
> >
>
> Shawn,
>
> You can drop this. I didn't see Peng's patch commit 706dd9d30d3b
> ("arm64: dts: imx8mp-venice-gw74xx: fix sai2 pin settings") which
> takes care of this.
>
> Best Regards,
>
> Tim

Shawn,

Did you need me to re-submit the series this patch was in without it?
I haven't seen any responses to the rest of the patches in this
series.

Best Regards,

Tim



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux