On 07/09/2022 22:49, Bhupesh Sharma wrote:
> As commit fc191af1bb0d ("net: stmmac: platform: Fix misleading
> interrupt error msg") noted, not every stmmac based platform
> makes use of the 'eth_wake_irq' or 'eth_lpi' interrupts.
>
> So, update the 'interrupt-names' inside 'snps,dwmac' YAML
> bindings to reflect the same.
>
> Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
> Cc: Rob Herring <robh@xxxxxxxxxx>
> Cc: Vinod Koul <vkoul@xxxxxxxxxx>
> Cc: David Miller <davem@xxxxxxxxxxxxx>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index f89ca308d55f..4d7fe4ee3d87 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -105,10 +105,12 @@ properties:
>
> interrupt-names:
> minItems: 1
> - items:
> - - const: macirq
> - - const: eth_wake_irq
> - - const: eth_lpi
> + maxItems: 3
> + contains:
> + enum:
> + - macirq
> + - eth_wake_irq
> + - eth_lpi
>
This gives quite a flexibility, e.g. missing macirq. Instead should be
probably a list with enums:
items:
- const: macirq
- enum: [eth_wake_irq, eth_lpi]
- enum: [eth_wake_irq, eth_lpi]
Best regards,
Krzysztof
