On 06/09/2022 12:55, Alexander Stein wrote: > Hi, > > thanks for the YAML conversion patch. > > Am Dienstag, 6. September 2022, 11:42:53 CEST schrieb Joy Zou: >> Convert the i.MX SDMA binding to DT schema format using json-schema. >> >> The compatibles fsl,imx31-to1-sdma, fsl,imx31-to2-sdma, fsl,imx35-to1-sdma >> and fsl,imx35-to2-sdma are not used. So need to delete it. The compatibles >> fsl,imx50-sdma, fsl,imx6sll-sdma and fsl,imx6sl-sdma are added. The >> original binding don't list all compatible used. >> >> In addition, add new peripheral types HDMI Audio. >> >> Signed-off-by: Joy Zou <joy.zou@xxxxxxx> >> --- >> Changes in v6: >> delete tag Acked-by from commit message. >> >> Changes in v5: >> modify the commit message fromat. >> add additionalProperties, because delete the quotes in patch v4. >> delete unevaluatedProperties due to similar to additionalProperties. >> modification fsl,sdma-event-remap items and description. >> >> Changes in v4: >> modify the commit message. >> delete the quotes in patch. >> modify the compatible in patch. >> delete maxitems and add items for clock-names property. >> add iram property. >> >> Changes in v3: >> modify the commit message. >> modify the filename. >> modify the maintainer. >> delete the unnecessary comment. >> modify the compatible and run dt_binding_check and dtbs_check. >> add clocks and clock-names property. >> delete the reg description and add maxItems. >> delete the interrupts description and add maxItems. >> add ref for gpr property. >> modify the fsl,sdma-event-remap ref type and add items. >> delete consumer example. >> >> Changes in v2: >> convert imx sdma bindings to DT schema. >> --- >> .../devicetree/bindings/dma/fsl,imx-sdma.yaml | 147 ++++++++++++++++++ >> .../devicetree/bindings/dma/fsl-imx-sdma.txt | 118 -------------- >> 2 files changed, 147 insertions(+), 118 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml >> delete mode 100644 Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt >> >> diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml >> b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml new file mode >> 100644 >> index 000000000000..3da65d3ea4af >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml >> @@ -0,0 +1,147 @@ >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/dma/fsl,imx-sdma.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Freescale Smart Direct Memory Access (SDMA) Controller for i.MX >> + >> +maintainers: >> + - Joy Zou <joy.zou@xxxxxxx> >> + >> +properties: > > Is it sensible to add something like this? > > $nodename: > pattern: "^dma-controller(@.*)?$" > > You are changing the node names in patch 3 anyway. > No, the device schemas do not need to enforce the name. The dma-controller schema enforces it, so what is missing here is to reference it. Best regards, Krzysztof
