On Mi, 2022-08-31 at 12:23 +0300, Farber, Eliav wrote: > On 8/31/2022 11:23 AM, Philipp Zabel wrote: > > On Di, 2022-08-30 at 19:22 +0000, Eliav Farber wrote: > > > Add optional "moortec,ts-series" property to define the temperature > > > equation and coefficients that shall be used to convert the digital > > > output to value in milli-Celsius. > > > Supported series: 5 (default) and 6. > > > > Is this the difference between mr75xxx and mr76xxx series? > > If so, should be a compatible "moortec,mr76006" instead? > > If the temperature equation could be derived from the compatible, this > > property would not be necessary. > The PVT (Process, Voltage, Temperature) monitoring logic can be > constructed from many different sub-blocks: > *) CONTROLLER (mr75203) - controlling TS, PD and VM. > *) TS (mr74137) - for measuring temperature in ring. > *) PD (mr74139) - for measuring IO based transistors. > *) VM (mr74138) - for measuring voltage rails across the SoC. > *) Ring oscillators (mr76007/mr76008) > *) Pre-scalers (mr76006) > > Besides mr75203 which is digital all other IPs are analog. > There is a single mr75203 and there can be several or none of the other > units. Thank you for the explanation, I think this information would be nice to have in a description in moortec,mr75203.yaml. > The kernel driver is only for the controller (mr75203). > The series 5 or 6 is relevant for the TS (mr74137) and not for the > controller (mr75203). > Each of the analog units can have a different series number (for example > we use series 3 of the VM). > > That is why I didn't change the compatible of mr75203, and instead added > a TS-series parameter. I see, I mistakenly assumed mr76006 referred to a new controller version. This also invalidates my comment on patch 4. regards Philipp