On 28/08/2022 23:57, Joel Selvaraj wrote: > There are two panel variants of Xiaomi Poco F1. Tianma and EBBG panel. > The previous beryllium dts supported the Tianma variant. In order to > add support for EBBG variant, the common nodes from beryllium dts are > moved to a new common dtsi and to make the variants distinguishable, > sdm845-xiaomi-beryllium.dts is now named as > sdm845-xiaomi-beryllium-tianma.dts. The board's model and compatible > properties are also renamed to distinguish between the variants. > So update the dt-bindings to reflect the new compatible value. > > Signed-off-by: Joel Selvaraj <joelselvaraj.oss@xxxxxxxxx> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index fb1d00bcc847..e465ca45c07f 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -666,7 +666,7 @@ properties: > - sony,akatsuki-row > - sony,apollo-row > - thundercomm,db845c > - - xiaomi,beryllium > + - xiaomi,beryllium-tianma The board compatibles are not that important for ABI yet this creates precedence, so I am against it. Simple renaming should not be a reason to change compatibles. Best regards, Krzysztof
