Re: [PATCH 0/5] arm64: dts: renesas: move I2C aliases to board files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Thu, Aug 25, 2022 at 8:37 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > I have never been a fan of the i2c aliases in the SoC-specific .dtsi files,
> > as aliases are typically board-specific.
> > We also don't have physical connectors labeled "i2c<N>" on any of
> > the affected boards.  But people like the i2c aliases, because i2c
>
> The reasoning here was that the busses were named like this in the
> schematics. Debugging was confusing if these numbers were mixed.

OK.

> > exposes the full buses to userspace, and the aliases fix the userspace
> > naming of /dev/i2c-<N> (I believe there is no better way to identify
> > i2c buses from userspace?).
>
> The proper way is udev rules.

Great!

> > So moving the i2c aliases to the board files is definitely a step in
> > the good direction.
> >
> > BTW, you missed r8a774a1.dtsi in your update.
>
> Okay, so I will send v2 with the above SoC converted as well?

Yes, please. Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux