On 19/08/2022 13:43, Siddharth Vadapalli wrote: >>>> Anyway the location is not correct. Regardless if this is if-then or >>>> allOf-if-then, put it just like example schema is suggesting. >>> >>> I will move the if-then statements to the lines above the >>> "additionalProperties: false" line. Also, I will add an allOf for this >> >> I had a look at the example at [1] and it uses allOf after the >> "additionalProperties: false" line. Would it be fine then for me to add >> allOf and the single if-then statement below the "additionalProperties: >> false" line? Please let me know. >> >> [1] -> https://github.com/devicetree-org/dt-schema/blob/mai/test/schemas/conditionals-allof-example.yaml > > Sorry, the correct link is: > https://github.com/devicetree-org/dt-schema/blob/main/test/schemas/conditionals-allof-example.yaml You are referring to tests? I did not suggest that. Please put it in place like example schema is suggesting: https://elixir.bootlin.com/linux/v5.19/source/Documentation/devicetree/bindings/example-schema.yaml Best regards, Krzysztof
