On Thu, 2022-08-18 at 16:40 +0300, Krzysztof Kozlowski wrote: > On 18/08/2022 15:51, Krzysztof Kozlowski wrote: > > On 18/08/2022 15:46, Johnson Wang wrote: > > > Add dt-binding documentation of timer for MediaTek MT8188 SoC > > > platform. > > > > > > Signed-off-by: Johnson Wang <johnson.wang@xxxxxxxxxxxx> > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > --- > > > Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | > > > 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > > > b/Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt > > > index f1c848af91d3..8bbb6e94508b 100644 > > > --- a/Documentation/devicetree/bindings/timer/mediatek,mtk- > > > timer.txt > > > +++ b/Documentation/devicetree/bindings/timer/mediatek,mtk- > > > timer.txt > > > @@ -25,6 +25,7 @@ Required properties: > > > For those SoCs that use SYST > > > * "mediatek,mt8183-timer" for MT8183 compatible timers (SYST) > > > * "mediatek,mt8186-timer" for MT8186 compatible timers (SYST) > > > + * "mediatek,mt8188-timer" for MT8188 compatible timers (SYST) > > > > Where is the driver change implementing this? > > Or is there a generic fallback and you just added a specific one (not > visible on the diff)? > > Best regards, > Krzysztof Hi Krzysztof, Yes, MT8188 uses "mediatek,mt6765-timer" as fallback compatible. BRs, Johnson Wang