On 22-08-15 09:30:33, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@xxxxxxx> > > There is build warning when CONFIG_OF is not selected. > >> drivers/clk/imx/clk-imx93.c:324:34: warning: 'imx93_clk_of_match' > >> defined but not used [-Wunused-const-variable=] > 324 | static const struct of_device_id imx93_clk_of_match[] = { > | ^~~~~~~~~~~~~~~~~~ > > Use CONFIG_OF to guard imx93_clk_of_match to avoid build warning. > > Fixes: 24defbe194b6 ("clk: imx: add i.MX93 clk") > Reported-by: kernel test robot <lkp@xxxxxxxxx> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > drivers/clk/imx/clk-imx93.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index f5c9fa40491c..5099048b7916 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -321,11 +321,13 @@ static int imx93_clocks_probe(struct platform_device *pdev) > return ret; > } > > +#ifdef CONFIG_OF Hmm, I'm not sure if we should do this or rather should we make this driver depend somehow on CONFIG_OF in Kconfig. Looking at the other i.MX clock drivers, it would seem we need this for all them too. I fairly OK with this, but maybe Stephen suggests something different. Reviewed-by: Abel Vesa <abel.vesa@xxxxxxx> > static const struct of_device_id imx93_clk_of_match[] = { > { .compatible = "fsl,imx93-ccm" }, > { /* Sentinel */ }, > }; > MODULE_DEVICE_TABLE(of, imx93_clk_of_match); > +#endif > > static struct platform_driver imx93_clk_driver = { > .probe = imx93_clocks_probe, > -- > 2.37.1 >