On Tue, 7 Oct 2014 10:47:05 +0200 Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Mon, Oct 06, 2014 at 04:07:03PM +0200, Boris Brezillon wrote: > > The HLCDC IP available in some Atmel SoCs (i.e. sam9x5i.e. at91sam9n12, > > at91sam9x5 family or sama5d3 family) provide a PWM device. > > > > The DT bindings used for this PWM device is following the default 3 cells > > bindings described in Documentation/devicetree/bindings/pwm/pwm.txt. > > > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/pwm/atmel-hlcdc-pwm.txt | 50 ++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > > > diff --git a/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > new file mode 100644 > > index 0000000..9f4f83a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/atmel-hlcdc-pwm.txt > > @@ -0,0 +1,50 @@ > > +Device-Tree bindings for Atmel's HLCDC (High LCD Controller) PWM driver > > + > > +The Atmel HLCDC PWM is subdevice of the HLCDC MFD device. > > +See ../mfd/atmel-hlcdc.txt for more details. > > + > > +Required properties: > > + - compatible: value should be one of the following: > > + "atmel,hlcdc-pwm" > > + - pinctr-names: the pin control state names. Should contain "default". > > + - pinctrl-0: should contain the pinctrl states described by pinctrl > > + default. > > + - #pwm-cells: should be set to 3. This PWM chip use the default 3 cells > > + bindings defined in Documentation/devicetree/bindings/pwm/pwm.txt. > > Maybe "... defined in pwm.txt in this directory."? No problem, I'll change that. > > > + > > +Example: > > + > > + hlcdc: hlcdc@f0030000 { > > + compatible = "atmel,sama5d3-hlcdc"; > > + reg = <0xf0030000 0x2000>; > > + clocks = <&lcdc_clk>, <&lcdck>, <&clk32k>; > > + clock-names = "periph_clk","sys_clk", "slow_clk"; > > + status = "disabled"; > > + > > + hlcdc-display-controller { > > + compatible = "atmel,hlcdc-display-controller"; > > + interrupts = <36 IRQ_TYPE_LEVEL_HIGH 0>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb888>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0>; > > + > > + hlcdc_panel_output: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&panel_input>; > > + }; > > + }; > > + }; > > Perhaps leave out the display controller node in this example since it > isn't relevant and could be confusing. Sure, I'll remove it. > > Both of the above are really only minor issues, so either way: > > Acked-by: Thierry Reding <thierry.reding@xxxxxxxxx> -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html