Hi Marc, On Sun, Jul 24, 2022 at 1:01 PM Marc Zyngier <maz@xxxxxxxxxx> wrote: > On Fri, 22 Jul 2022 16:11:54 +0100, > Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > > > > Update description for '#interrupt-cells' property to utilize the > > RZG2L_{NMI,IRQX} for the first cell defined in the > > include/dt-bindings/interrupt-controller/irqc-rzg2l.h file. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > v3: > > * New patch > > --- a/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > > +++ b/Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > > @@ -31,8 +31,9 @@ properties: > > - const: renesas,rzg2l-irqc > > > > '#interrupt-cells': > > - description: The first cell should contain external interrupt number (IRQ0-7) and the > > - second cell is used to specify the flag. > > + description: The first cell should contain a macro RZG2L_{NMI,IRQX} included in the > > + include/dt-bindings/interrupt-controller/irqc-rzg2l.h and the second > > + cell is used to specify the flag. > > I think a binding should be self describing, and not rely on an opaque > macro. Mentioning that there is a macro that encodes it is fine, but > the values are what matter, specially when considering that other OSs > could (and should be able to) write their own DTs from scratch without > depending on something that is very much Linux-specific. The macros are not Linux-specific, and are part of the bindings. But the only hard dependency on <dt-bindings/interrupt-controller/irqc-rzg2l.h> is the DT source file describing the board. Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds