On Fri, Jul 29, 2022 at 05:15:01PM +0200, Balsam CHIHI wrote: > On Tue, Jul 26, 2022 at 10:09 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > > > On Tue, 26 Jul 2022 15:55:02 +0200, Balsam CHIHI wrote: > > > This patch adds dt-binding documents for mt8192 and mt8195 thermal controllers. > > > > > > Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx> > > > Signed-off-by: Balsam CHIHI <bchihi@xxxxxxxxxxxx> > > > --- > > > .../thermal/mediatek,mt8192-lvts.yaml | 73 ++++++++++++++++++ > > > .../thermal/mediatek,mt8195-lvts.yaml | 75 +++++++++++++++++++ > > > 2 files changed, 148 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,mt8192-lvts.yaml > > > create mode 100644 Documentation/devicetree/bindings/thermal/mediatek,mt8195-lvts.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > Error: Documentation/devicetree/bindings/thermal/mediatek,mt8195-lvts.example.dts:32.36-37 syntax error > > FATAL ERROR: Unable to parse input tree > > make[1]: *** [scripts/Makefile.lib:383: Documentation/devicetree/bindings/thermal/mediatek,mt8195-lvts.example.dtb] Error 1 > > make[1]: *** Waiting for unfinished jobs.... > > make: *** [Makefile:1404: dt_binding_check] Error 2 > > > > doc reference errors (make refcheckdocs): > > > > See https://patchwork.ozlabs.org/patch/ > > > > This check can fail if there are any dependencies. The base for a patch > > series is generally the most recent rc1. > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > date: > > > > pip3 install dtschema --upgrade > > > > Please check and re-submit. > > > > Hello Rob, > > This error only appear when I apply my series directly on top of linux-5.19.rc8. > But, when I apply the other two series that mine depends on, > > https://patchwork.kernel.org/project/linux-pm/cover/20220722200007.1839356-1-daniel.lezcano@xxxxxxxxxx/ > https://patchwork.kernel.org/project/linux-mediatek/cover/20220523093346.28493-1-rex-bc.chen@xxxxxxxxxxxx/ How was I supposed to know that if you don't document that in the patch? > and run "dt_binding_check" again against my YAML file, it does not > print the error you found above. > Would you check it, please? No. Resend after rc1 and checks will be based on that. Rob
