Re: [PATCH v5 06/14] iio: magnetometer: yas530: Rename functions and registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

On 08.08.22 13:08, Andy Shevchenko wrote:
> On Mon, Aug 8, 2022 at 1:03 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote:
>>
>> This is a preparation for adding YAS537 variant.
> 
> the YAS537

OK

>> Functions that are used only by YAS530, YAS532 and YAS533 are renamed from
>> yas5xx to yas530. Same for the registers.
>>
>> To avoid part listing in function and registers names, the name of the first
>> variant is used. Where appropriate, comments were added that these functions
>> are used by more than one variant.
>>
>> Functions that will be used by all variants including YAS537 remain in the
>> naming scheme yas5xx. Or YAS5XX for registers, respectively.
> 
> ..
> 
>>  /**
>> - * yas5xx_get_measure() - Measure a sample of all axis and process
>> + * yas530_get_measure() - Measure a sample of all axis and process
>>   * @yas5xx: The device state
>>   * @to: Temperature out
>>   * @xo: X axis out
>>   * @yo: Y axis out
>>   * @zo: Z axis out
>>   * @return: 0 on success or error code
> 
>> + * Used by YAS530, YAS532 and YAS533
> 
> In this case (multi-line comment) the period should be added to the
> sentence. Ditto for other similar cases.

OK

>>   */

...

Kind regards,
Jakob



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux