On Mon, Aug 8, 2022 at 1:03 AM Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote: > > This is a preparation for adding YAS537 variant. the YAS537 > Functions that are used only by YAS530, YAS532 and YAS533 are renamed from > yas5xx to yas530. Same for the registers. > > To avoid part listing in function and registers names, the name of the first > variant is used. Where appropriate, comments were added that these functions > are used by more than one variant. > > Functions that will be used by all variants including YAS537 remain in the > naming scheme yas5xx. Or YAS5XX for registers, respectively. ... > /** > - * yas5xx_get_measure() - Measure a sample of all axis and process > + * yas530_get_measure() - Measure a sample of all axis and process > * @yas5xx: The device state > * @to: Temperature out > * @xo: X axis out > * @yo: Y axis out > * @zo: Z axis out > * @return: 0 on success or error code > + * Used by YAS530, YAS532 and YAS533 In this case (multi-line comment) the period should be added to the sentence. Ditto for other similar cases. > */ Otherwise the change looks good. So, if you address these, Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> -- With Best Regards, Andy Shevchenko
