On 05/08/2022 16:06, Dzmitry Sankouski wrote: > сб, 18 июн. 2022 г. в 04:54, Krzysztof Kozlowski < > krzysztof.kozlowski@xxxxxxxxxx>: > >> On 17/06/2022 05:20, Dzmitry Sankouski wrote: >>> New device support - Xiaomi Mi6 phone >>> >>> What works: >>> - storage >>> - wlan >>> - touchscreen >>> >>> Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 1 + >>> .../boot/dts/qcom/msm8998-xiaomi-sagit.dts | 12 + >>> .../boot/dts/qcom/msm8998-xiaomi-sagit.dtsi | 628 ++++++++++++++++++ >>> 3 files changed, 641 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dtsi >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile >> b/arch/arm64/boot/dts/qcom/Makefile >>> index 2f8aec2cc6db..aa50843dbe12 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -48,6 +48,7 @@ dtb-$(CONFIG_ARCH_QCOM) += >> msm8998-oneplus-dumpling.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-lilac.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += msm8998-xiaomi-sagit.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts >> b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts >>> new file mode 100644 >>> index 000000000000..0791615ec5da >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts >>> @@ -0,0 +1,12 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* Copyright (c) 2016, The Linux Foundation. All rights reserved. */ >>> + >>> +/dts-v1/; >>> + >>> +#include "msm8998-xiaomi-sagit.dtsi" >>> + >>> +/ { >>> + model = "Xiaomi Mi 6"; >>> + compatible = "xiaomi,sagit", "qcom,msm8998"; >> >> You need to document the compatible. >> > You mean a document file with all msm8998 boards compatible properties > info, like for example, stm did in > Documentation/devicetree/bindings/arm/stm32/stm32.yaml ? I mean, add it to existing bindings with Qualcomm board compatibles. Best regards, Krzysztof