On Fri, Aug 05, 2022 at 11:23:12AM +0200, Johan Hovold wrote:
> The HID pin configurations belong in the HID nodes rather than i2c bus
> node.
>
> Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
Thanks,
Mani
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 16 ++++++++++++++--
> 1 file changed, 14 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index 47192e9cf7a4..ae8be1b743ce 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -194,16 +194,20 @@ &qup0_i2c4 {
> clock-frequency = <400000>;
>
> pinctrl-names = "default";
> - pinctrl-0 = <&qup0_i2c4_default>, <&ts0_default>;
> + pinctrl-0 = <&qup0_i2c4_default>;
>
> status = "okay";
>
> touchscreen@10 {
> compatible = "hid-over-i2c";
> reg = <0x10>;
> +
> hid-descr-addr = <0x1>;
> interrupts-extended = <&tlmm 175 IRQ_TYPE_LEVEL_LOW>;
> vdd-supply = <&vreg_misc_3p3>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&ts0_default>;
> };
> };
>
> @@ -219,24 +223,32 @@ &qup2_i2c5 {
> clock-frequency = <400000>;
>
> pinctrl-names = "default";
> - pinctrl-0 = <&qup2_i2c5_default>, <&kybd_default>, <&tpad_default>;
> + pinctrl-0 = <&qup2_i2c5_default>;
>
> status = "okay";
>
> touchpad@15 {
> compatible = "hid-over-i2c";
> reg = <0x15>;
> +
> hid-descr-addr = <0x1>;
> interrupts-extended = <&tlmm 182 IRQ_TYPE_LEVEL_LOW>;
> vdd-supply = <&vreg_misc_3p3>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&tpad_default>;
> };
>
> keyboard@68 {
> compatible = "hid-over-i2c";
> reg = <0x68>;
> +
> hid-descr-addr = <0x1>;
> interrupts-extended = <&tlmm 104 IRQ_TYPE_LEVEL_LOW>;
> vdd-supply = <&vreg_misc_3p3>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&kybd_default>;
> };
> };
>
> --
> 2.35.1
>
--
மணிவண்ணன் சதாசிவம்
