On 02/08/2022 11:25, Jiucheng Xu wrote: > > On 2022/8/2 16:04, Krzysztof Kozlowski wrote: >> [ EXTERNAL EMAIL ] >> >> On 01/08/2022 08:00, Jiucheng Xu wrote: >>> Add binding documentation for the Amlogic G12 series DDR >>> performance monitor unit. >>> >>> Signed-off-by: Jiucheng Xu <jiucheng.xu@xxxxxxxxxxx> >>> --- >>> Changes v2 -> v3: >>> - Remove oneOf >>> - Add descriptions >>> - Fix compiling warning >>> >>> Changes v1 -> v2: >>> - Rename file, from aml_ddr_pmu.yaml to amlogic,g12_ddr_pmu.yaml >>> - Delete "model", "dmc_nr", "chann_nr" new properties >>> - Fix compiling error >>> --- >>> .../bindings/perf/amlogic,g12_ddr_pmu.yaml | 51 +++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 52 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >>> new file mode 100644 >>> index 000000000000..961656d4db6e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/perf/amlogic,g12_ddr_pmu.yaml >>> @@ -0,0 +1,51 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/perf/amlogic,g12-ddr-pmu.yaml# >> You still did not test the bindings... >> >> You received such comment (with instructions how to do it) and still >> decided to send untested bindings. >> >> That's not how submission procces should look like. >> >> NAK, till you send something which you actually test. >> >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > > Thanks for your time. I think I got a wrong understanding. > > As the binding doc says, I run the following command to check: > > # make dt_binding_check DT_SCHEMA_FILES=amlogic,g12_ddr_pmu.yaml ARCH=arm64 Ah, cool, thanks. > > I saw the warning/errors in v2 patch, and thanks to your comments let > them gone. > > But I didn't see any warning/errors keywords printing in v3 except the > message as below: > > "$id: relative path/filename doesn't match actual path or filename". > > > I admit I didn't understand this prompt. I found the doc in example says > that: > > # $id is a unique identifier based on the filename. There may or may not > be a > # file present at the URL. > > So I thought that was not warning/errors prompt. Unfortunately, it is and warning message. The final part of this ID is directory and filename - these must match real file path. > > Today, I find the root cause of the warning/errors prompt. > > I think I have fixed it and the building log is so quiet. > > > This is my first upstream patch, TBH I even didn't know what is binding > before. > > In order to upstream my driver, I try to learn how to write binding scheme. > > It looks like I still did terribly. > > I think my stupid misunderstanding get you angry. I'm sorry for wasting > your time and comments. Apologies for being harsh. We all make mistakes and hopefully learn from them. > > I will re-submit v4 to fix it. > Awesome, thank you! Best regards, Krzysztof
