Re: [PATCH v5 0/4] Qualcomm SPMI PMIC pin controller drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed 01 Oct 09:30 PDT 2014, Ivan T. Ivanov wrote:

> Changes since v4:
> 
> - Use PMIC name in compatible string.
> - PINCTRL_QCOM_SPMI_PMIC from Kconfig symbol.
> - Remove pmic string from drivers file names.
> - Fixed coding style issues.
> - Use qcom-spmi-gpio and qcom-spmi-mpp from dirver names,
>   to be similar to qcom-spmi-iadc, qcom-spmi-vadc and 
>   qcom-spmi-temp-alarm drivers.
> 
> Short description:
> 
> Patches adds pin control drivers for Multi-Purpose Pin (MPP) and
> General-purpose pin (GPIO) controllers found in Qualcomm SPMI based
> PMIC chips.
> 
> MPP's are enhanced GPIO's with analog circuits, which support 
> analog and digital input/output.
> 
> v4: https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg725568.html
> 
> Bjorn Andersson (1):
>   pinctrl: Device tree bindings for Qualcomm PMIC GPIO block
> 
> Ivan T. Ivanov (3):
>   pinctrl: Device tree bindings for Qualcomm PMIC MPP block
>   pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver
>   pinctrl: Qualcomm SPMI PMIC MPP pin controller driver
> 
>  .../devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 215 +++++
>  .../devicetree/bindings/pinctrl/qcom,pmic-mpp.txt  | 162 ++++
>  drivers/pinctrl/qcom/Kconfig                       |  13 +
>  drivers/pinctrl/qcom/Makefile                      |   2 +
>  drivers/pinctrl/qcom/pinctrl-spmi-gpio.c           | 937 ++++++++++++++++++++
>  drivers/pinctrl/qcom/pinctrl-spmi-mpp.c            | 953 +++++++++++++++++++++
>  include/dt-bindings/pinctrl/qcom,pmic-gpio.h       | 142 +++
>  include/dt-bindings/pinctrl/qcom,pmic-mpp.h        |  44 +
>  8 files changed, 2468 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,pmic-mpp.txt
>  create mode 100644 drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
>  create mode 100644 drivers/pinctrl/qcom/pinctrl-spmi-mpp.c
>  create mode 100644 include/dt-bindings/pinctrl/qcom,pmic-gpio.h
>  create mode 100644 include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> 

This looks good and I gave it a spin on one of our 8974 devices and verified
that gpio_keys works :)

Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxxxxxx>

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux