On 21/07/2022 12:38, Peng Fan wrote: >> Subject: Re: [PATCH V3 3/7] dt-bindings: soc: imx: add i.MX8MP vpu blk ctrl >> >> On 19/07/2022 11:58, Peng Fan wrote: >>>>> + interconnects: >>>>> + items: >>>>> + - description: G1 decoder interconnect >>>>> + - description: G2 decoder interconnect >>>>> + - description: VC8000E encoder interconnect >>>>> + >>>>> + interconnect-names: >>>>> + items: >>>>> + - const: g1 >>>>> + - const: g2 >>>>> + - const: vc8000e >>>> >>>> Include interconnects+names in list of all properties and disallow >>>> them for other variants. >>> >>> I not understand well about >>> " Include interconnects+names in list of all properties ", could you >>> please explain a bit more? >>> >>> And there is already an "if" to check whether the compatible contains >>> " fsl,imx8mp-vpu-blk-ctrl" to make sure the interconnect valid for >>> i.MX8MP, so it is not valid to other variants. >> >> Defining properties in some if: clause is not really readable and >> maintainable. The properties should be defined in top-level properties:. > > Maybe I should also include i.MX8MM interconnect and make it > a separate patch, then i.MX8MP/i.MX8MM just use their own > names just like other properities. In final, as below: > > Tow patch: > 1. Add interconnect property for i.MX8MM VPU BLK CTRL > 2. Add i.MX8MP VPU BLK CTRL dt bindings > > In top-level: > + interconnects: > + maxItems: 3 > > + interconnect-names: > + maxItems: 3 > > For i.MX8MM > + interconnects: > + items: > + - description: G1 decoder interconnect > + - description: G2 decoder interconnect > + - description: H1 encoder interconnect > + > + interconnect-names: > + items: > + - const: g1 > + - const: g2 > + - const: h1 > > For i.MX8MP: > + interconnects: > + items: > + - description: G1 decoder interconnect > + - description: G2 decoder interconnect > + - description: VC8000E encoder interconnect > + > + interconnect-names: > + items: > + - const: g1 > + - const: g2 > + - const: vc8000e > > How do you think? I don't understand what is the question here to me. Shall I tell you what to do or not to do with iMX 8MM? I don't know. I am not a maintainer of that SoC. Best regards, Krzysztof
