On 19/07/2022 07:50, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@xxxxxxx> > > i.MX8MP VPU blk ctrl module has similar design as i.MX8MM, so reuse > the i.MX8MM VPU blk ctrl yaml file. And add description for the items. > > Signed-off-by: Peng Fan <peng.fan@xxxxxxx> > --- > .../soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml | 90 +++++++++++++++++-- > include/dt-bindings/power/imx8mp-power.h | 4 + > 2 files changed, 85 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml > index b3fb529b399c..14f92574286f 100644 > --- a/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx8mm-vpu-blk-ctrl.yaml > @@ -30,20 +30,13 @@ properties: > maxItems: 4 > > power-domain-names: > - items: > - - const: bus > - - const: g1 > - - const: g2 > - - const: h1 > + maxItems: 4 > > clocks: > maxItems: 3 > > clock-names: > - items: > - - const: g1 > - - const: g2 > - - const: h1 > + maxItems: 3 > > required: > - compatible > @@ -53,6 +46,85 @@ required: > - clocks > - clock-names > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mm-vpu-blk-ctrl > + then: > + properties: > + power-domains: > + items: > + - description: bus power domain > + - description: G1 decoder power domain > + - description: G2 decoder power domain > + - description: H1 encoder power domain > + > + power-domain-names: > + items: > + - const: bus > + - const: g1 > + - const: g2 > + - const: h1 > + > + clocks: > + items: > + - description: G1 decoder clk > + - description: G2 decoder clk > + - description: H1 encoder clk > + > + clock-names: > + items: > + - const: g1 > + - const: g2 > + - const: h1 > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mp-vpu-blk-ctrl > + then: > + properties: > + power-domains: > + items: > + - description: bus power domain > + - description: G1 decoder power domain > + - description: G2 decoder power domain > + - description: VC8000E encoder power domain > + > + power-domain-names: > + items: > + - const: bus > + - const: g1 > + - const: g2 > + - const: vc8000e > + > + clocks: > + items: > + - description: G1 decoder clk > + - description: G2 decoder clk > + - description: VC8000E encoder clk > + > + clock-names: > + items: > + - const: g1 > + - const: g2 > + - const: vc8000e > + > + interconnects: > + items: > + - description: G1 decoder interconnect > + - description: G2 decoder interconnect > + - description: VC8000E encoder interconnect > + > + interconnect-names: > + items: > + - const: g1 > + - const: g2 > + - const: vc8000e Include interconnects+names in list of all properties and disallow them for other variants. Best regards, Krzysztof