On 21/07/2022 12:38, Benjamin Mugnier wrote:
Hi Bryan,
On 24/05/2022 16:02, Bryan O'Donoghue wrote:
V2:
- Adds fix for bug identified by Vladimir
The CCI i2c_adapter_add() and pm_runtime_enable() are racy.
This is a generic problem not related to the rb5/imx577 but, for the sake
of our conversation/review's context I'll add it into this series.
- Include Vladimir's camcc patch
I've also opted to include Vladimir's disable of camcc to make the enable
of it in my patchset logical.
- Move address/size cells Konrad
- Remove newline in pin definitions - Konrad
- Remove sensor 'status = "okay"' - Konrad
- Add comment to qrb5165-rb5.dts re: imx412 and imx577 difference - Konrad
- Move pin definitions to 8250 dtsi - Vladimir
- Drop power domain from sensor definition - Vladimir
- Correct to "add to cam2" not "cam1" in commit log - bod
To make verification of the CCI race eaiser I've provided a defconfig both
with and without modules enabled.
Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-24-05-22%2bimx577-rb5
Link: https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-24-05-22%2bimx577-rb5-compiled-in
git diff linaro/linux-next-22-05-22+imx577-rb5 linaro/linux-next-24-05-22+imx577-rb5
V1:
Linux-next now has everything we need to switch on this sensor both in the
qcom DTS and in the imx412 driver.
After this, no further dts or driver work is required to capture images on
the RB5.
Here's a bootable linux-next with a kernel config. I added Vladimir's
power-domain changes on-top to verify nothing breaks for me.
https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-18-05-22%2bimx577-rb5
Bryan O'Donoghue (3):
i2c: qcom-cci: Fix ordering of pm_runtime_xx and i2c_add_adapter
arm64: dts: qcom: sm8250: camss: Define ports address/size cells
arm64: dts: qcom: qrb5165-rb5: Enable the IMX577 on cam2
Vladimir Zapolskiy (1):
arm64: dts: qcom: sm8250: Disable camcc by default
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 60 ++++++++++++++++++++++++
arch/arm64/boot/dts/qcom/sm8250.dtsi | 39 +++++++++++++++
drivers/i2c/busses/i2c-qcom-cci.c | 14 ++++--
3 files changed, 108 insertions(+), 5 deletions(-)
I successfully tested this series with the st-vgxy61 sensor instead of the imx577. I can't provide comments on the device tree patch for the imx577 in 4/4.
For patches 1/4, 2/4, and 3/4:
Tested-by: Benjamin Mugnier <benjamin.mugnier@xxxxxxxxxxx>
Thanks again for your work.
Appreciated.
I'll V3 this series once we sort out the naming of the imx sensor.
https://patchwork.kernel.org/project/linux-media/list/?series=660483
