On 21/07/2022 04:46, Quan Nguyen wrote: > > > On 20/07/2022 17:34, Krzysztof Kozlowski wrote: >> On 20/07/2022 10:52, Quan Nguyen wrote: >>> Document Ampere Mt.Mitchell BMC board compatible. >>> >>> Signed-off-by: Quan Nguyen <quan@xxxxxxxxxxxxxxxxxxxxxx> >> >> Thank you for your patch. There is something to discuss/improve. >> >>> --- >>> v2: >>> + Introduce in v2 to add Ampere Mt. Mitchell BMC compatible [Krzysztof] >>> >>> Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> index d61408194998..b8146d5c4431 100644 >>> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml >>> @@ -71,6 +71,7 @@ properties: >>> - enum: >>> - aspeed,ast2600-evb >>> - aspeed,ast2600-evb-a1 >>> + - ampere,mtmitchell-bmc >> >> Put the entry ordered alphabetically. >> > > Thanks Krzysztof for the review. > > Will change to : > - enum: > + - ampere,mtmitchell-bmc > - aspeed,ast2600-evb > - aspeed,ast2600-evb-a1 > > But, should we correct the below as well? ie: to move > "ampere,mtjade-bmc" to before "aspeed,ast2500-evb" ? > Oops, indeed, I added aspeed in wrong place. I'll correct it in my tree. Best regards, Krzysztof
