On 2022-07-21 02:07, William Zhang wrote:
Add generic bcm94908.dts file. Signed-off-by: William Zhang <william.zhang@xxxxxxxxxxxx> --- arch/arm64/boot/dts/broadcom/bcmbca/Makefile | 1 + .../boot/dts/broadcom/bcmbca/bcm94908.dts | 30 +++++++++++++++++++ 2 files changed, 31 insertions(+) create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile index d30fa75f0611..27741b71ba9e 100644 --- a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile +++ b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_BCMBCA) += \ bcm4906-tplink-archer-c2300-v1.dtb \ bcm4908-asus-gt-ac5300.dtb \ bcm4908-netgear-raxe500.dtb \ + bcm94908.dtb \ bcm4912-asus-gt-ax6000.dtb \ bcm94912.dtb \ bcm963158.dtb \
AFAIU bcm94908 is a reference board name. I think I see some inconsistency in naming Broadcom's reference boards DTS files. If you take a look at in-kernel DTS files: find ./arch/arm*/boot/dts/ -name "*.dts" 99% of them are prefixed with family/SoC name. I did the same for bcm4908 (and Northstar) boards. So it's <soc>-<manufacturer>-<model>.dts e.g. bcm4908-asus-gt-ac5300.dts To match that I *think* you should actually call your file: bcm4908-bcm94908 (or bcm4908-94908 depending on actual board name) First of all: am I correct here? Secondly: could you do that? I know many DTS files named ignoring SoC/ family prefix. Still maybe we could change it as some (this) point?
