On Wed, 2022-07-20 at 19:37 +0200, Krzysztof Kozlowski wrote: > On 20/07/2022 15:31, Lee Jones wrote: > > On Wed, 20 Jul 2022, Tinghan Shen wrote: > > > > > The System Control Processor System (SCPSYS) has several power > > > management related tasks in the system. Add the bindings for it. > > > > > > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx> > > > > Why have you ignored my review comments from v2? > > If you refer whether the binding is needed at all, then the answer is > yes, because this is not simple syscons but a device with children, > which we want to parse/match. > > Anyway Tinghan should respond to you about way how he proceeds... > > Best regards, > Krzysztof Hi Lee, I'm so sorry for not answering your feedback. I misunderstood it that you're waiting the review result of DT maintainers. This binding is added because of the discussion of the scpsys node[1]. I first looked at mfd/syscon.yaml to see if I could use it. I found that it doesn't have the 'simple-mfd' compatible, so I decide to add a new one. It's because I need the 'simple-mfd' compatible to parse child nodes. [1] https://lore.kernel.org/all/f7eee4e8-05fa-4c83-9168-64e5ea4c510f@xxxxxxxxxx/ Best regards, TingHan