On Wed, 20 Jul 2022, Tinghan Shen wrote: > The System Control Processor System (SCPSYS) has several power > management related tasks in the system. Add the bindings for it. > > Signed-off-by: Tinghan Shen <tinghan.shen@xxxxxxxxxxxx> Why have you ignored my review comments from v2? > --- > .../bindings/mfd/mediatek,mt8195-scpsys.yaml | 68 +++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml b/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml > new file mode 100644 > index 000000000000..4117a6dbc19c > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/mediatek,mt8195-scpsys.yaml > @@ -0,0 +1,68 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/mediatek,mt8195-scpsys.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek System Control Processor System > + > +maintainers: > + - MandyJH Liu <mandyjh.liu@xxxxxxxxxxxx> > + > +description: > + MediaTek System Control Processor System (SCPSYS) has several > + power management tasks. The tasks include MTCMOS power > + domain control, thermal measurement, DVFS, etc. > + > +properties: > + compatible: > + items: > + - enum: > + - mediatek,mt8167-scpsys > + - mediatek,mt8173-scpsys > + - mediatek,mt8183-scpsys > + - mediatek,mt8192-scpsys > + - mediatek,mt8195-scpsys > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > +patternProperties: > + "^power-controller(@[0-9a-f]+)?$": > + $ref: /schemas/power/mediatek,power-controller.yaml# > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/mt8195-clk.h> > + #include <dt-bindings/power/mt8195-power.h> > + > + syscon@10006000 { > + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd"; > + reg = <0x10006000 0x100>; > + > + spm: power-controller { > + compatible = "mediatek,mt8195-power-controller"; > + #address-cells = <1>; > + #size-cells = <0>; > + #power-domain-cells = <1>; > + > + /* sample of power domain nodes */ > + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY { > + reg = <MT8195_POWER_DOMAIN_PCIE_PHY>; > + #power-domain-cells = <0>; > + }; > + > + power-domain@MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY { > + reg = <MT8195_POWER_DOMAIN_SSUSB_PCIE_PHY>; > + #power-domain-cells = <0>; > + }; > + }; > + }; -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
