On Fri, Aug 27, 2021 at 02:42:58PM +0800, Richard Zhu wrote: > Convert the fsl,imx6q-pcie.txt into a schema. > - ranges property should be grouped by region, with no functional > changes. > - only one propert is allowed in the compatible string, remove > "snps,dw-pcie". > > Signed-off-by: Richard Zhu <hongxing.zhu@xxxxxxx> > --- > .../bindings/pci/fsl,imx6q-pcie.txt | 100 --------- > .../bindings/pci/fsl,imx6q-pcie.yaml | 202 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 203 insertions(+), 101 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > create mode 100644 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt > -Optional properties: > -- fsl,tx-deemph-gen1: Gen1 De-emphasis value. Default: 0 > -- fsl,tx-deemph-gen2-3p5db: Gen2 (3.5db) De-emphasis value. Default: 0 > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > + fsl,tx-deemph-gen1: > + description: Gen1 De-emphasis value (optional required). > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 0 > + > + fsl,tx-deemph-gen2-3p5db: > + description: Gen2 (3.5db) De-emphasis value (optional required). > + $ref: /schemas/types.yaml#/definitions/uint32 > + default: 0 What does "optional required" mean in all these properties? "Optional" is the opposite of "required."