On Wednesday 01 October 2014 11:11:46 Darren Hart wrote: > > > >No, I think in absence of drv->acpi_match_table ACPI core should just go > >and > >use drv->of_match_table to do the matching and be done with it. > > But then you will match drivers that have of-only support that don't know > anything about ACPI and haven't been updated to use the new API. Worse, > some of those drivers will assume of node structs and such and potentially > panic. Unless I'm sorry mistaken here.... > I don't think that is a huge danger: most drivers tend to check for the presence of dev->of_node before calling any of the DT interfaces, you'd only ever enter the probe function if the compatible string matches (i.e. an old kernel with a new ACPI table), and most users of ACPI systems will disable CONFIG_OF at compile time, so the accessors looking at the of_node are not there. In theory it's possible that something goes wrong here, but it's not very likely to ever cause problems. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
