+Geert, Ulf "jinkun.hong" <jinkun.hong@xxxxxxxxxxxxxx> writes: > From: "jinkun.hong" <jinkun.hong@xxxxxxxxxxxxxx> > > Use PM Domain framework to manage the clock. Which clock? This changelog needs a more thorough description. Also, with this series alone, it's not clear how the power-domain transitions ever happen, since I don't see any devices hooked up to your power domains, or do I see your platform using runtime PM. In order for this to be reviewed properely, it's important for reviewers to be able to see how this PM domain support will be used. Also, remember that the DT is supposed to reflect the hardware, not the design choices of linux drivers. Because of that, it's a little surprising to see clocks as properties of a power domain because clocks are usually properties of devices. I suggest you have a look at the sh-mobile implementation of DT-based power domains by Geert[1], which shows how he's hooking up device clocks. Kevin [1] http://marc.info/?l=linux-pm&m=141166256415448&w=2 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
