On 14/07/2022 10:34, Volodymyr Kharuk wrote: > Add device tree binding of the mlx7502x and update MAINTAINERS > > Signed-off-by: Volodymyr Kharuk <vkh@xxxxxxxxxxx> Wrong subject prefix. Remove trailing "binding". > --- > .../bindings/media/i2c/melexis,mlx7502x.yaml | 146 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 147 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/melexis,mlx7502x.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/melexis,mlx7502x.yaml b/Documentation/devicetree/bindings/media/i2c/melexis,mlx7502x.yaml > new file mode 100644 > index 000000000000..4ac91f7a26b6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/melexis,mlx7502x.yaml > @@ -0,0 +1,146 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/melexis,mlx7502x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Melexis ToF 7502x MIPI CSI-2 Sensor > + > +maintainers: > + - Volodymyr Kharuk <vkh@xxxxxxxxxxx> > + > +description: |- > + Melexis ToF 7502x sensors has a CSI-2 output. It supports 2 and 4 lanes, > + and mipi speeds are 300, 600, 704, 800, 904, 960Mbs. Supported format is RAW12. > + Sensor 75026 is QVGA, while 75027 is VGA sensor. > + If you use compatible = "melexis,mlx7502x", then autodetect will be called. > + > +properties: > + compatible: > + items: No items. You have just one item. > + - enum: > + - melexis,mlx7502x > + - melexis,mlx75026 > + - melexis,mlx75027 > + > + reg: > + maxItems: 1 > + > + assigned-clocks: true > + assigned-clock-parents: true > + assigned-clock-rates: true These are not needed. > + > + clocks: > + description: Clock frequency 8MHz > + maxItems: 1 > + > + vdda-supply: > + description: > + Definition of the regulator used as analog power supply(2.7V). s/Definition of the regulator used as // (redundant) > + > + vddif-supply: > + description: > + Definition of the regulator used as interface power supply(1.8V). s/Definition of the regulator used as // > + > + vddd-supply: > + description: > + Definition of the regulator used as digital power supply(1.2V). s/Definition of the regulator used as // > + > + vdmix-supply: > + description: > + Definition of the regulator used as mixed driver power supply(1.2V). s/Definition of the regulator used as // > + > + reset-gpios: > + maxItems: 1 > + description: Reset Sensor GPIO Control (active low) > + > + melexis,trig-gpios: > + maxItems: 1 > + description: > + Hardware Trigger GPIO Control (active low) > + When the hardware trigger mode is enabled, this GPIO is used to generate > + a low level impulse for about 100us. The impulse triggers a new > + measurement cycle. > + > + melexis,leden-gpios: > + maxItems: 1 > + description: > + Led driver enable GPIO Control (active high) > + This GPIO notifies the illumination driver when it is safe to use led > + signals from the sensor. > + > + port: > + description: MIPI CSI-2 transmitter port > + $ref: /schemas/graph.yaml#/$defs/port-base > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + oneOf: > + - items: > + - const: 1 > + - const: 2 > + - items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + > + clock-noncontinuous: true > + link-frequencies: true You do not need these two, they come from video-interfaces.yaml > + > + required: > + - data-lanes > + - link-frequencies > + > +required: > + - compatible > + - reg > + - clocks > + - port > + Best regards, Krzysztof
