On 12.07.2022 19:32, Krzysztof Kozlowski wrote: > On 12/07/2022 18:25, Sergiu Moga wrote: >> Convert SPI DT binding for Atmel/Microchip SoCs to json-schema. >> >> Signed-off-by: Sergiu Moga <sergiu.moga@xxxxxxxxxxxxx> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> >> v1 -> v2: >> - change subject headline prefix from "dt-bindings: spi" to "spi: atmel" >> - change maintainer >> - kept the compatbile as items (instead of switching to enums) and at91rm9200 >> as fallback for sam9x60, since the evolution of IP's is incremental. >> - removed unnecessay "cs-gpios" property and descriptions >> - added min/max for fifo-size property. >> >> >> v2 -> v3: >> - change subject headline prefix from "spi: atmel" to >> "spi: dt-bindings: atmel,at91rm9200-spi: convert to json-schema" >> - use enum instead of a range for "atmel,fifo-size" >> >> >> .../bindings/spi/atmel,at91rm9200-spi.yaml | 76 +++++++++++++++++++ >> .../devicetree/bindings/spi/spi_atmel.txt | 36 --------- >> 2 files changed, 76 insertions(+), 36 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >> delete mode 100644 Documentation/devicetree/bindings/spi/spi_atmel.txt >> >> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >> new file mode 100644 >> index 000000000000..084897cc8f66 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >> @@ -0,0 +1,76 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/spi/atmel,spi.yaml# > You need to test the bindings. > My apologies, I did notice the related error locally, but I somehow forgot to amend the commit before formatting the patch and sending it. I am sorry about this. >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Atmel SPI device >> + >> +maintainers: >> + - Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx> >> + >> +allOf: >> + - $ref: spi-controller.yaml# >> + >> +properties: >> + compatible: >> + oneOf: >> + - items: > I missed that part - this is one item, so no "items". You are right, should be just a const I guess. Thank you. > Best regards, > Krzysztof Regards, Sergiu
