On Tue, 12 Jul 2022 19:25:55 +0300, Sergiu Moga wrote: > Convert SPI DT binding for Atmel/Microchip SoCs to json-schema. > > Signed-off-by: Sergiu Moga <sergiu.moga@xxxxxxxxxxxxx> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > > v1 -> v2: > - change subject headline prefix from "dt-bindings: spi" to "spi: atmel" > - change maintainer > - kept the compatbile as items (instead of switching to enums) and at91rm9200 > as fallback for sam9x60, since the evolution of IP's is incremental. > - removed unnecessay "cs-gpios" property and descriptions > - added min/max for fifo-size property. > > > v2 -> v3: > - change subject headline prefix from "spi: atmel" to > "spi: dt-bindings: atmel,at91rm9200-spi: convert to json-schema" > - use enum instead of a range for "atmel,fifo-size" > > > .../bindings/spi/atmel,at91rm9200-spi.yaml | 76 +++++++++++++++++++ > .../devicetree/bindings/spi/spi_atmel.txt | 36 --------- > 2 files changed, 76 insertions(+), 36 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml > delete mode 100644 Documentation/devicetree/bindings/spi/spi_atmel.txt > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml: properties:enum: [16, 32] is not of type 'object', 'boolean' from schema $id: http://json-schema.org/draft-07/schema# ./Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/spi/atmel,at91rm9200-spi.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml: ignoring, error in schema: properties: enum Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.example.dtb:0:0: /example-0/spi@fffcc000: failed to match any schema with compatible: ['atmel,at91rm9200-spi'] Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.example.dtb:0:0: /example-0/spi@fffcc000/mmc@0: failed to match any schema with compatible: ['mmc-spi-slot'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
