On 13/07/2022 06:51, Dongjin Yang wrote: > Add Samsung System manager driver and Secure Service code. > Samsung System manager is for SoCs produced by Samsung Foundry > to provide system read/write request by System Manager API. > Samsung Secure service is for SoCs produced by Samsung Foundry > to provide secure monitor service using Trusted Foundations. > 1. You need to provide users of these drivers. For the syscon-regmap-export driver (better name than manager which does not manager anything), having a user would answer the question why such weird driver is needed. Since there is no user and driver's behavior breaks design choices, it has to be NAKed. 2. Thread your submissions properly. Git send email does it automatically for you. You can use other tools, but then be sure your patches are properly threaded. This patchset was not which makes review more difficult than it should. Best regards, Krzysztof
