Hi Krzysztof, On 2022-07-12 at 17:12 +02, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > On 12/07/2022 16:19, Mikhail Rudenko wrote: >> Add device-tree binding documentation for OV4689 image sensor driver, >> and the relevant MAINTAINERS entries. >> >> Signed-off-by: Mikhail Rudenko <mike.rudenko@xxxxxxxxx> >> --- >> .../bindings/media/i2c/ovti,ov4689.yaml | 122 ++++++++++++++++++ >> MAINTAINERS | 7 + >> 2 files changed, 129 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml >> >> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml >> new file mode 100644 >> index 000000000000..6bdebe5862b4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml >> @@ -0,0 +1,122 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov4689.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Omnivision OV4689 CMOS Sensor Device Tree Bindings > > s/Device Tree Bindings// Ack, will fix in v2. >> + >> +maintainers: >> + - Mikhail Rudenko <mike.rudenko@xxxxxxxxx> >> + >> +description: |- > > No need for - > Ack >> + The Omnivision OV4689 is a high performance, 1/3-inch, 4 megapixel >> + image sensor. Ihis chip supports high frame rate speeds up to 90 fps >> + at 2688x1520 resolution. It is programmable through an I2C >> + interface, and sensor output is sent via 1/2/4 lane MIPI CSI-2 >> + connection. >> + >> +allOf: >> + - $ref: /schemas/media/video-interface-devices.yaml# >> + >> +properties: >> + compatible: >> + const: ovti,ov4689 >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-names: >> + description: >> + External clock for the sensor. > > This goes to clocks instead. > Ack >> + items: >> + - const: xclk > > No need for clock-names for such case. > Ack >> + >> + dovdd-supply: >> + description: >> + Definition of the regulator used as Digital I/O voltage supply. > > s/Definition of the regulator used as // > > It's redundant... > Ack >> + >> + avdd-supply: >> + description: >> + Definition of the regulator used as Analog voltage supply. > > Ditto > Ack >> + >> + dvdd-supply: >> + description: >> + Definition of the regulator used as Digital core voltage supply. > > Ditto > Ack >> + >> + powerdown-gpios: >> + maxItems: 1 >> + description: >> + Reference to the GPIO connected to the powerdown pin (active low). > > s/Reference to the// > Ack >> + >> + reset-gpios: >> + maxItems: 1 >> + description: >> + Reference to the GPIO connected to the reset pin (active low). > > The same. > Ack >> + >> + orientation: true >> + >> + rotation: true >> + >> + port: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + additionalProperties: false >> + description: >> + Output port node, single endpoint describing the CSI-2 transmitter. >> + >> + properties: >> + endpoint: >> + $ref: /schemas/media/video-interfaces.yaml# >> + unevaluatedProperties: false >> + > > Best regards, > Krzysztof Thanks for review! By the way, I used an existing schema for a similar sensor ("ovti,ov02a10.yaml", specifically) as an example, and your notes apply to it too. Looks like it should also be fixed... -- Best regards, Mikhail Rudenko
