Re: [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/11/22 18:04, Mimi Zohar wrote:
Hi Stefan,

On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote:
-       /*
-        * For both vtpm/tpm, firmware has log addr and log size in big
-        * endian format. But in case of vtpm, there is a method called
-        * sml-handover which is run during kernel init even before
-        * device tree is setup. This sml-handover function takes care
-        * of endianness and writes to sml-base and sml-size in little
-        * endian format. For this reason, vtpm doesn't need conversion
-        * but physical tpm needs the conversion.
-        */

This comment is dropped.  Perhaps not in such detail, but shouldn't a
comment or function description exist in the new function.

I am adding back the comment in v7.


Otherwise,
Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>

thanks,

Mimi


_______________________________________________
kexec mailing list
kexec@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/kexec



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux