Hi Stefan, On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote: > - /* > - * For both vtpm/tpm, firmware has log addr and log size in big > - * endian format. But in case of vtpm, there is a method called > - * sml-handover which is run during kernel init even before > - * device tree is setup. This sml-handover function takes care > - * of endianness and writes to sml-base and sml-size in little > - * endian format. For this reason, vtpm doesn't need conversion > - * but physical tpm needs the conversion. > - */ This comment is dropped. Perhaps not in such detail, but shouldn't a comment or function description exist in the new function. Otherwise, Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx> thanks, Mimi
