On 07/07/2022 10:37, LABBE Corentin wrote: > Le Wed, Jul 06, 2022 at 05:25:21PM +0200, Krzysztof Kozlowski a écrit : >> On 06/07/2022 16:28, LABBE Corentin wrote: >>> Le Wed, Jul 06, 2022 at 07:29:04AM -0600, Rob Herring a écrit : >>>> On Wed, 06 Jul 2022 09:04:04 +0000, Corentin Labbe wrote: >>>>> The latest addition to the rockchip crypto driver need to update the >>>>> driver bindings. >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >>>>> Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> >>>>> --- >>>>> .../crypto/rockchip,rk3288-crypto.yaml | 85 +++++++++++++++++-- >>>>> 1 file changed, 77 insertions(+), 8 deletions(-) >>>>> >>>> >>>> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >>>> on your patch (DT_CHECKER_FLAGS is new in v5.13): >>>> >>>> yamllint warnings/errors: >>>> >>>> dtschema/dtc warnings/errors: >>>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/crypto/rockchip,rk3288-crypto.yaml: allOf:0:then:properties:clock-names: 'oneOf' conditional failed, one must be fixed: >>>> [{'const': 'aclk'}, {'const': 'hclk'}, {'const': 'sclk'}, {'const': 'apb_pclk'}] is too long >>>> [{'const': 'aclk'}, {'const': 'hclk'}, {'const': 'sclk'}, {'const': 'apb_pclk'}] is too short >>>> False schema does not allow 4 >>>> 1 was expected >>>> 4 is greater than the maximum of 2 >>>> 4 is greater than the maximum of 3 >>> >>> Hello >>> >>> I upgraded to dt-schema 2022.07 and fail to reproduce all errors. >> >> Visible on older dtschema (2022.6.dev10+gcd64f75fe091), visible on >> newest (2022.7). >> >> Exactly the same error. >> > > Hello > > I am sorry, I finally succesfully reproduced it. > Just doing what the hints gives (removing max/min-items) from "static" list fix the issue. Not sure what do you mean by "static list". I think you should drop min/maxItems from clock-names/reset-names in allOf:if:then sections. > Does I need to remove your Reviewed-by ? Let's drop, so it will be back to my to-review queue. Best regards, Krzysztof