Re: [PATCH v5 3/4] edac: Add APM X-Gene SoC EDAC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Sat, Aug 23, 2014 at 1:23 AM, Loc Ho <lho@xxxxxxx> wrote:
> This patch adds support for the APM X-Gene SoC EDAC driver. It
> requires ARM64 EDAC support patch [1] to compile due to
> dependence on MC module which calls an unused software memory
> scrub function.
>
> [1] http://www.spinics.net/lists/arm-kernel/msg324093.html
>
> Signed-off-by: Feng Kan <fkan@xxxxxxx>
> Signed-off-by: Loc Ho <lho@xxxxxxx>
> ---
>  drivers/edac/Kconfig      |    9 +-
>  drivers/edac/Makefile     |    3 +
>  drivers/edac/xgene_edac.c | 2132 +++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 2143 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/edac/xgene_edac.c
>
[...]
> +#ifdef CONFIG_OF
> +static struct of_device_id xgene_edac_mc_of_match[] = {
> +       { .compatible = "apm,xgene-edac-mc" },
> +       {},
> +};
> +MODULE_DEVICE_TABLE(of, xgene_edac_of_match);
> +#endif

Something I apparently forgot to mention when I tested v3 was that I
had to manually fix this up to get it to build:

diff --git a/drivers/edac/xgene_edac.c b/drivers/edac/xgene_edac.c
index d69c2e5..2f436d45 100644
--- a/drivers/edac/xgene_edac.c
+++ b/drivers/edac/xgene_edac.c
@@ -452,7 +452,7 @@ static struct of_device_id xgene_edac_mc_of_match[] = {
     { .compatible = "apm,xgene-edac-mc" },
     {},
 };
-MODULE_DEVICE_TABLE(of, xgene_edac_of_match);
+MODULE_DEVICE_TABLE(of, xgene_edac_mc_of_match);
 #endif

 static struct platform_driver xgene_edac_mc_driver = {
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux