Am 2022-07-05 11:11, schrieb haibo.chen@xxxxxxx:
From: Haibo Chen <haibo.chen@xxxxxxx> Not all platform currently supports octal DTR mode. lx2160a do not implement DQS, this causes flash probe failure and therefore, provide an option of quirk FSPI_QUIRK_DISABLE_DTR for platforms not support DTR mode.
You write "DQS is not supported" but your quirk targets DTR. DTR works without DQS. DQS is needed for faster frequencies, no? So the quirk should be named accordingly. Also, this compatible is (unfortunately!) also used on for the LS1028A SoC and as far as I know DQS is supported there. I'm not sure what to do here. Maybe add a new compatible "nxp,ls1028a-fspi" and change the device tree to compatible = "nxp,ls1028a-fspi", "nxp,lx2160a"; -michael