Re: [PATCH 11/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 05, 2022 at 12:12:25PM +0200, Krzysztof Kozlowski wrote:
> On 05/07/2022 11:42, Johan Hovold wrote:
> > Drop the unnecessary "lane" suffix from the PHY reset names and mark the
> > old names as deprecated.
> > 
> > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > ---
> >  .../phy/qcom,msm8996-qmp-pcie-phy.yaml        | 20 +++++++++++--------
> >  1 file changed, 12 insertions(+), 8 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml
> > index 7931b1fd1476..0bea8270b37e 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,msm8996-qmp-pcie-phy.yaml
> > @@ -94,11 +94,15 @@ patternProperties:
> >            - description: PHY (lane) reset
> >  
> >        reset-names:
> > -        items:
> > -          - enum:
> > -              - lane0
> > -              - lane1
> > -              - lane2
> > +        oneOf:
> > +          - items:
> > +              - const: lane
> > +          - items:
> > +              - enum:
> > +                  - lane0
> > +                  - lane1
> > +                  - lane2
> > +            deprecated: true
> >  
> 
> How about just dropping reset-names entirely? Marking entire field
> deprecated and removing from DTS? The same in the previous patch.
> 
> Usually one-item xxx-names do not bring any useful information.

Yeah, I agree, that's better.

Johan



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux