Hi, Bo-Chen: On Fri, 2022-07-01 at 11:58 +0800, Bo-Chen Chen wrote: > This driver will support dp_intf and there are many configs between > dpi > and dp_intf. Therefore, we will add many configs in "struct > mtk_dpi_conf". > To let this structure more readable, we add this kernel doc. Applied to mediatek-drm-next [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, CK > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@xxxxxxxxxxxx> > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@xxxxxxxxxxxxx> > Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx> > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c > b/drivers/gpu/drm/mediatek/mtk_dpi.c > index e61cd67b978f..f66a121ba0c9 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -118,6 +118,15 @@ struct mtk_dpi_yc_limit { > u16 c_bottom; > }; > > +/** > + * struct mtk_dpi_conf - Configuration of mediatek dpi. > + * @cal_factor: Callback function to calculate factor value. > + * @reg_h_fre_con: Register address of frequency control. > + * @max_clock_khz: Max clock frequency supported for this SoCs in > khz units. > + * @edge_sel_en: Enable of edge selection. > + * @output_fmts: Array of supported output formats. > + * @num_output_fmts: Quantity of supported output formats. > + */ > struct mtk_dpi_conf { > unsigned int (*cal_factor)(int clock); > u32 reg_h_fre_con;