Hi Krzysztof,
On Mon, Jun 20, 2022 at 5:56 AM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 13/06/2022 21:56, Brad Larson wrote:
> > From: Brad Larson <blarson@xxxxxxx>
> >
> > Add support for the AMD Pensando Elba SoC System Resource chip
> > using the SPI interface. The Elba SR is a Multi-function Device
> > supporting device register access using CS0, smbus interface for
> > FRU and board peripherals using CS1, dual Lattice I2C masters for
> > transceiver management using CS2, and CS3 for flash access.
> >
> > Signed-off-by: Brad Larson <blarson@xxxxxxx>
> > ---
> > .../bindings/mfd/amd,pensando-elbasr.yaml | 93 +++++++++++++++++++
> > 1 file changed, 93 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mfd/amd,pensando-elbasr.yaml
> ...
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/reset/amd,pensando-elba-reset.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + spi0 {
>
> Just "spi"
Changed to spi
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + num-cs = <4>;
> > +
> > + spi@0 {
>
> "spi" is for SPI controllers. Use generic name matching the device.
> Usually this is "system-controller", however Rob pointed out your
> inaccurate bindings and example.
Proposed the below change node in the reply to Rob. The model I
followed for this was the Altera mfd/altera-a10sr.c
spi@0 {
sr_regs@0 {
rstc: reset-controller@0 {
dw_i2c@1 {
lattice_i2c@2 {
flash@3 {
Regards,
Brad
