On Wed, Jun 29, 2022 at 11:14 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Wed, Jun 29, 2022 at 4:29 PM Aidan MacDonald > <aidanmacdonald.0x0@xxxxxxxxx> wrote: > > > > Changes in v4: > > > > * Drop regmap-irq patches and rebase on top of the regmap-irq > > refactoring series[1], which implements the same functionality. > > * Reorder mfd_cells, putting one-line entries at the bottom. > > * Fix incorrect example in axp192-gpio device tree bindings. > > * Perform adc_en2 flag -> adc_en2_mask conversion in axp20x_adc > > as a separate patch. > > * Simplify axp192_usb_power_set_current_max(). > > * Drop unneeded OF dependency in pin control driver, and document > > tables used for describing register layouts. > > * Various style fixups suggested by Andy Shevchenko. > > > For patches 6-11 > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> Ditto for patches 13-15. Very good made series, thanks! > > This patch series adds support for the X-Powers AXP192 PMIC to the > > AXP20x driver framework. > > > > The first patch is a small change to regmap-irq to support the AXP192's > > unusual IRQ register layout. It isn't possible to include all of the > > IRQ registers in one regmap-irq chip without this. > > > > The rest of the changes are pretty straightforward, I think the only > > notable parts are the axp20x_adc driver where there seems to be some > > opportunities for code reuse (the axp192 is nearly a duplicate of the > > axp20x) and the addition of a new pinctrl driver for the axp192, since > > the axp20x pinctrl driver was not very easy to adapt. -- With Best Regards, Andy Shevchenko
