On Mon, Jun 27, 2022 at 01:29:33PM +0530, Vidya Sagar wrote: > > > On 6/24/2022 8:09 PM, Serge Semin wrote: > > External email: Use caution opening links or attachments > > > > > > Since the DW PCIe common code now supports the IP-core version > > auto-detection there is no point in manually setting the version up for the > > controllers newer than v4.70a. Seeing Tegra 194 PCIe Host and EP > > controllers are based on the DW PCIe v4.90a IP-core we can freely drop the > > dw_pcie.version field initialization. > > > > Suggested-by: Rob Herring <robh@xxxxxxxxxx> > > Signed-off-by: Serge Semin <Sergey.Semin@xxxxxxxxxxxxxxxxxxxx> > > > > --- > > > > Folks, I don't have Tegra 194 PCIe hw instance to test it out. Could you > > please make sure this patch doesn't brake anything? > > Hi, > I tried to apply the series > https://patchwork.kernel.org/project/linux-pci/list/?series=653624 on top of > linux-next and ran into conflicts. Could you please tell me the minimum set > of patches to be taken? Hi. As the cover letter says it is supposed to be applied on top of the next series *: https://lore.kernel.org/linux-pci/20220624143428.8334-1-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/ * Currently latest patchset version is v5. Then - the resent series what you are referring to. -Sergey > > Thanks, > Vidya Sagar > > > > > Changelog v3: > > - This is a new patch create as a result of the discussion: > > https://lore.kernel.org/linux-pci/20220503214638.1895-6-Sergey.Semin@xxxxxxxxxxxxxxxxxxxx/ > > --- > > drivers/pci/controller/dwc/pcie-tegra194.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > > index f24b30b7454f..e497e6de8d15 100644 > > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > > @@ -1979,7 +1979,6 @@ static int tegra194_pcie_probe(struct platform_device *pdev) > > pci->ops = &tegra_dw_pcie_ops; > > pci->n_fts[0] = N_FTS_VAL; > > pci->n_fts[1] = FTS_VAL; > > - pci->version = DW_PCIE_VER_490A; > > > > pp = &pci->pp; > > pp->num_vectors = MAX_MSI_IRQS; > > -- > > 2.35.1 > >