On Sat, 25 Jun 2022, Ilpo Järvinen wrote: > On Thu, 23 Jun 2022, Lino Sanfilippo wrote: > > > On 23.06.22 at 18:29, Andy Shevchenko wrote: > > > On Wed, Jun 22, 2022 at 05:46:56PM +0200, Lino Sanfilippo wrote: > > >> From: Lino Sanfilippo <l.sanfilippo@xxxxxxxxxx> > > >> > > >> The maximum allowed delay for RTS before and RTS after send is 100 ms. > > >> Adjust the documentation accordingly. > > > > > > > > > Is it only documentation issue? If the code allows this to be set higher > > > than 100, we may not change the documentation since this an ABI (from > > > firmware <--> kernel perspective) we need to support old variants. > > > > > > > Well currently the documentation claims that a maximum of 1000 msecs is allowed but > > nothing actually checks the values read from device tree/ACPI and so it is possible > > to set much higher values (note that the UART drivers dont check the delays read from > > DT/ACPI either, the only exception I found is max310x which clamps it to 15 ms). > > > > We already have a maximum of 100 ms defined for RTS delays set via TIOCSRS485. To be > > consistent with TIOCSRS485 the same limit is used for DT/ACPI values in this patch. > > > > I am aware that this changes the firmware/kernel ABI. But we had a similar situation when > > the sanity checks for TIOCSRS485 were introduced > > (see https://lore.kernel.org/all/20220410104642.32195-2-LinoSanfilippo@xxxxxx/) > > since before we did not have those limits for all drivers (some drivers clamped the > > values itself but many did not care). > > Furthermore 100 ms is already a very high value for RTS delays (which are usually rather > > in usecs range). So IMHO the risk is very low to break anything when values are clamped > > that are higher than that. > > Did you see this development direction (from Lukas): > > https://lore.kernel.org/linux-serial/20220309125908.GA9283@xxxxxxxxx/ > > ? > > Effectively, he wants to making a compat threshold at 1msec and beyond > that the input value would be interpreted as nsecs. I was thinking this more the other day and came up with the idea of adding SER_RS485_DELAY_RTS_NSEC and SER_RS485_DELAY_RTS_MSEC flags instead of magic threshold and deprecate specifying those delays w/o either flag. That way we'd not need to change behavior and we provide an easy way to keep the delay in msec if somebody really wants (just for the sake of getting rid of the warning). -- i.
