Hi, [...] > > + > > + soc { > > + leds { > > I think leds are board level devices and do not have to be under node > "soc"? > @Shawn, Yes, it is. @Jingchang, For now we could just remove the led nodes here. There hasn't any real leds On QDS(and for now we have to test their output pulse). So this could be added later when need. > > + compatible = "pwm-leds"; > > Please have a new line between property list and device node ... > This and the following issues about led will be fixed when adding this node separately In the future. [...] Thanks, BRs Xiubo -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html