Re: [PATCH v3 1/8] iio: magnetometer: yas530: Change data type of hard_offsets to signed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jonathan,

On 18.06.22 16:18, Jonathan Cameron wrote:
>
> On Sat, 18 Jun 2022 02:13:09 +0200
> Jakob Hauser <jahau@xxxxxxxxxxxxxx> wrote:
> 
>> The "hard_offsets" are currently unsigned u8 but they should be signed as they
>> can get negative. They are signed in function yas5xx_meaure_offsets() and in the
>> Yamaha drivers [1][2].
>>
>> [1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156
>> [2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91
>>
>> Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530")
>> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> Trivial but it's nice to clean out CC if you also have a tag from the person.
> All the automation will generally send emails to anyone who has given a tag
> so the CC doesn't add anything at this point
> 
> I try to drop cases of this when applying patches, but if it's done by
> the submitter it makes my life a little easier!

I didn't know, thanks for explaining. I'll remove the redundant Cc's.

Kind regards,
Jakob

...



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux