On Mon, 2022-06-20 at 09:35 +0200, Krzysztof Kozlowski wrote: > On 20/06/2022 05:06, Liu Ying wrote: > > On Sun, 2022-06-19 at 14:11 +0200, Krzysztof Kozlowski wrote: > > > On 18/06/2022 11:22, Liu Ying wrote: > > > > This patch adds bindings for Mixel LVDS PHY found on > > > > Freescale i.MX8qm SoC. > > > > > > > > Signed-off-by: Liu Ying <victor.liu@xxxxxxx> > > > > --- > > > > .../bindings/phy/mixel,lvds-phy.yaml | 64 > > > > +++++++++++++++++++ > > > > 1 file changed, 64 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/phy/mixel,lvds-phy.yaml > > > > diff --git a/Documentation/devicetree/bindings/phy/mixel,lvds- > > > > phy.yaml b/Documentation/devicetree/bindings/phy/mixel,lvds- > > > > phy.yaml > > > > new file mode 100644 > > > > index 000000000000..de964ffb9356 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/phy/mixel,lvds-phy.yaml > > > > @@ -0,0 +1,64 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: > > > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fphy%2Fmixel%2Clvds-phy.yaml%23&data=05%7C01%7Cvictor.liu%40nxp.com%7Cc7d6216ac12148ec95d008da528f78eb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637913073407696040%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=m588CiXOaJhWFbpEal3MjZaHtvOTUOVIujydIdPxSHg%3D&reserved=0 > > > > +$schema: > > > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cvictor.liu%40nxp.com%7Cc7d6216ac12148ec95d008da528f78eb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637913073407696040%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IGn5f05QrzyX05k%2FKgTitdq6OYN2FmdpsO6qHXun55Y%3D&reserved=0 > > > > + > > > > +title: Mixel LVDS PHY for Freescale i.MX8qm SoC > > > > > > If Mixel is a vendor, it needs it's vendor prefix documented and > > > used > > > in > > > compatible. Filename should match compatible. If it is not a > > > vendor, > > > then filename should be "fsl,imx8qm-lvds-phy.yaml" > > > > Mixel is a vendor. I'll document the vendor prefix and set > > 'fsl,imx8qm-lvds-phy' and 'mixel,lvds-phy' as compatible's enum. > > I'll keep the filename as-is. > > mixel,lvds-phy is not a good compatible (and filename) because it is > not > specific about component version. Please use specific compatibles > only > thus also specific filename (filename should match first compatible). All the information about component version I can find in the PHY IP's data sheet is '28FDSOI-LVDS-1250-8CH-TX-PLL'. '28FDSOI' looks like the technology name. Do you think the compatible name can be 'mixel,lvds-1250-8ch-tx-pll'? Or, any better option? If the compatible name is ok, does the below compabitle property look ok? ===================8<============== compatible: enum: - mixel,lvds-1250-8ch-tx-pll - fsl,imx8qm-lvds-phy ===================8<============== I'll change the filename accordingly. Thanks, Liu Ying
